On Wed, Mar 24, 2021 at 07:57:57AM -0700, Dave Jiang wrote: > > On 3/24/2021 6:56 AM, Jason Gunthorpe wrote: > > On Tue, Mar 23, 2021 at 08:44:29AM -0700, Dave Jiang wrote: > > > > > 1. Introduce UACCE framework support for idxd and have a wq driver resides > > > under drivers/misc/uacce/idxd to support the char device operations and > > > deprecate the current custom char dev in idxd. This should remove the burden > > > on you to deal with the char device. > > Gah, I feel I already complained at Intel for cramming their own > > private char devices into subsystems! *subsystems* define the user > > API, not random drivers in them. > > > > uacce is a reasonable place to put something like this if there isn't > > a multi-driver standard > > > > If this is the plan we should block of the char dev under > > CONFIG_EXPERIMENTAL or something to discourage people using the uAPI > > we are planning to delete > The whole reason to move to UACCE is to relieve Vinod the burden of having > to review that code under dmaengine. It was unfortunate that UACCE showed up > a kernel version later after the idxd driver was accepted. Do you have a > better suggestion? No, I said it is a reasonable thing to do Jason