>> + dma_dev->dst_addr_widths = PT_DMA_WIDTH(dma_get_mask(pt->dev)); >> + dma_dev->directions = DMA_MEM_TO_MEM; >> + dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; >> + dma_cap_set(DMA_MEMCPY, dma_dev->cap_mask); >> + dma_cap_set(DMA_INTERRUPT, dma_dev->cap_mask); >> + dma_cap_set(DMA_PRIVATE, dma_dev->cap_mask); > > Why DMA_PRIVATE for a memcpy function? This DMA engine is intended to use with AMD NTB IP and not for general purpose DMA, hence set the cap as DMA_PRIVATE. Otherwise this DMA engine will be used for system DMA. Please correct me if my understanding is not right. Also, I have implemented all of the comments for this patch except this. if this is fine, will send the next version for review. Thanks, Sanjay > -- > ~Vinod >
