> -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx] > Sent: Friday, October 30, 2020 3:01 AM > To: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx> > Cc: Vinod Koul <vkoul@xxxxxxxxxx>; dmaengine <dmaengine@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH 09/10] dmaengine: ste_dma40: remove redundant irqsave > and irqrestore in hardIRQ > > On Fri, Oct 16, 2020 at 2:03 AM Barry Song <song.bao.hua@xxxxxxxxxxxxx> > wrote: > > > Running in hardIRQ, disabling IRQ is redundant. > > > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> > > That's right! > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Thanks, Linus. I guess you missed v2 in which you actually should have acked :-) https://lore.kernel.org/dmaengine/20201027215252.25820-10-song.bao.hua@xxxxxxxxxxxxx/ Thanks Barry > > Yours, > Linus Walleij