On 2020/10/16 7:59, Barry Song wrote: > Running in hardIRQ, disabling IRQ is redundant. > > Cc: Zhou Wang <wangzhou1@xxxxxxxxxxxxx> > Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx> Thanks for fixing this :) Acked-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx> > --- > drivers/dma/hisi_dma.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c > index e1a958ae7925..a259ee010e9b 100644 > --- a/drivers/dma/hisi_dma.c > +++ b/drivers/dma/hisi_dma.c > @@ -431,9 +431,8 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) > struct hisi_dma_dev *hdma_dev = chan->hdma_dev; > struct hisi_dma_desc *desc; > struct hisi_dma_cqe *cqe; > - unsigned long flags; > > - spin_lock_irqsave(&chan->vc.lock, flags); > + spin_lock(&chan->vc.lock); > > desc = chan->desc; > cqe = chan->cq + chan->cq_head; > @@ -452,7 +451,7 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) > chan->desc = NULL; > } > > - spin_unlock_irqrestore(&chan->vc.lock, flags); > + spin_unlock(&chan->vc.lock); > > return IRQ_HANDLED; > } >
