On 16/10/2020 2.59, Barry Song wrote:
> Running in hardIRQ, disabling IRQ is redundant.
Subject should be: dmaengine: ti: k3-udma: ...
Other than that:
Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx>
> ---
> drivers/dma/ti/k3-udma.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index 82cf6c77f5c9..e508280b3d70 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -1020,13 +1020,12 @@ static irqreturn_t udma_ring_irq_handler(int irq, void *data)
> {
> struct udma_chan *uc = data;
> struct udma_desc *d;
> - unsigned long flags;
> dma_addr_t paddr = 0;
>
> if (udma_pop_from_ring(uc, &paddr) || !paddr)
> return IRQ_HANDLED;
>
> - spin_lock_irqsave(&uc->vc.lock, flags);
> + spin_lock(&uc->vc.lock);
>
> /* Teardown completion message */
> if (cppi5_desc_is_tdcm(paddr)) {
> @@ -1077,7 +1076,7 @@ static irqreturn_t udma_ring_irq_handler(int irq, void *data)
> }
> }
> out:
> - spin_unlock_irqrestore(&uc->vc.lock, flags);
> + spin_unlock(&uc->vc.lock);
>
> return IRQ_HANDLED;
> }
> @@ -1086,9 +1085,8 @@ static irqreturn_t udma_udma_irq_handler(int irq, void *data)
> {
> struct udma_chan *uc = data;
> struct udma_desc *d;
> - unsigned long flags;
>
> - spin_lock_irqsave(&uc->vc.lock, flags);
> + spin_lock(&uc->vc.lock);
> d = uc->desc;
> if (d) {
> d->tr_idx = (d->tr_idx + 1) % d->sglen;
> @@ -1103,7 +1101,7 @@ static irqreturn_t udma_udma_irq_handler(int irq, void *data)
> }
> }
>
> - spin_unlock_irqrestore(&uc->vc.lock, flags);
> + spin_unlock(&uc->vc.lock);
>
> return IRQ_HANDLED;
> }
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
