On 16/10/2020 00:59, Barry Song wrote:
> Running in hardIRQ, disabling IRQ is redundant.
>
> Cc: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> Cc: Jon Hunter <jonathanh@xxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx>
> ---
> drivers/dma/tegra210-adma.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index c5fa2ef74abc..4735742e826d 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -408,19 +408,18 @@ static irqreturn_t tegra_adma_isr(int irq, void *dev_id)
> {
> struct tegra_adma_chan *tdc = dev_id;
> unsigned long status;
> - unsigned long flags;
>
> - spin_lock_irqsave(&tdc->vc.lock, flags);
> + spin_lock(&tdc->vc.lock);
>
> status = tegra_adma_irq_clear(tdc);
> if (status == 0 || !tdc->desc) {
> - spin_unlock_irqrestore(&tdc->vc.lock, flags);
> + spin_unlock(&tdc->vc.lock);
> return IRQ_NONE;
> }
>
> vchan_cyclic_callback(&tdc->desc->vd);
>
> - spin_unlock_irqrestore(&tdc->vc.lock, flags);
> + spin_unlock(&tdc->vc.lock);
>
> return IRQ_HANDLED;
> }
>
Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
Cheers
Jon
--
nvpublic
