On 08-10-20, 19:34, Manivannan Sadhasivam wrote: > On Wed, Oct 07, 2020 at 02:01:13PM +0530, Vinod Koul wrote: > > Driver doesn't use keyword enum for enum owl_dmadesc_offsets resulting > > in warning: > > > > drivers/dma/owl-dma.c:139: warning: cannot understand function prototype: > > 'enum owl_dmadesc_offsets ' > > > > So add the keyword to fix it and also add documentation for missing > > OWL_DMADESC_SIZE > > > > Do we really need to document the max value? Does it produce any warning? It does.. Once you add the enum, it will treat is as such and look at members and complain that the OWL_DMADESC_SIZE is not documented ;) -- ~Vinod
