Looks good to me > From: dmaengine-owner@xxxxxxxxxxxxxxx <dmaengine- > Sent: Saturday, 12 September 2020 10:22 > > This eliminates the following sparse warning: > > drivers/dma/ioat/dma.c:29:5: warning: symbol 'completion_timeout' was > not declared. Should it be static? > drivers/dma/ioat/dma.c:33:5: warning: symbol 'idle_timeout' was not > declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx> > --- > drivers/dma/ioat/dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c > index a814b200299b..8cce4e059b7a 100644 > --- a/drivers/dma/ioat/dma.c > +++ b/drivers/dma/ioat/dma.c > @@ -26,11 +26,11 @@ > > #include "../dmaengine.h" > > -int completion_timeout = 200; > +static int completion_timeout = 200; > module_param(completion_timeout, int, 0644); > MODULE_PARM_DESC(completion_timeout, > "set ioat completion timeout [msec] (default 200 [msec])"); > -int idle_timeout = 2000; > +static int idle_timeout = 2000; > module_param(idle_timeout, int, 0644); > MODULE_PARM_DESC(idle_timeout, > "set ioat idel timeout [msec] (default 2000 [msec])"); > -- > 2.25.4
