Re: 6b41030fdc790 broke dmatest badly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 9/4/20 6:34 PM, Andy Shevchenko wrote:
> It becomes a bit annoying to fix dmatest after almost each release.
> The commit 6b41030fdc79 ("dmaengine: dmatest: Restore default for channel")
> broke my use case when I tried to start busy channel.
> 
> So, before this patch
> 	...
> 	echo "busy_chan" > channel
> 	echo 1 > run
> 	sh: write error: Device or resource busy
> 	[ 1013.868313] dmatest: Could not start test, no channels configured
> 
> After I have got it run on *ALL* available channels.

Is not that controlled with max_channels? 

> 
> dmatest compiled as a module.
> 
> Fix this ASAP, otherwise I will send revert of this and followed up patch next
> week.
>

I don't quite get it, you are sending revert and then a fix rather then helping
with a fix? What is reason for such extreme (and non-cooperative) flow?

P.S.
Unfortunately, I do not have access to hardware to run reproducer.

Cheers
Vladimir



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux