Re: [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/13/2020 11:35 PM, Randy Dunlap wrote:
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Fix build errors when CONFIG_PCI_MSI is not enabled by making the
driver depend on PCI_MSI:

ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
Cc: dmaengine@xxxxxxxxxxxxxxx
Cc: Vinod Koul <vkoul@xxxxxxxxxx>

Vinod, I submitted this fix patch last week:
https://patchwork.kernel.org/patch/11649231/

But I think maybe Randy's patch may be more preferable? You can apply this one and ignore my submission.

---
  drivers/dma/Kconfig |    1 +
  1 file changed, 1 insertion(+)

--- mmotm-2020-0713-1949.orig/drivers/dma/Kconfig
+++ mmotm-2020-0713-1949/drivers/dma/Kconfig
@@ -285,6 +285,7 @@ config INTEL_IDMA64
  config INTEL_IDXD
  	tristate "Intel Data Accelerators support"
  	depends on PCI && X86_64
+	depends on PCI_MSI
  	depends on SBITMAP
  	select DMA_ENGINE
  	help





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux