Hi Jon, More stirring in the cesspool ;-) On Tue, Jun 23, 2020 at 12:13 PM Jon Hunter <jonathanh@xxxxxxxxxx> wrote: > On 21/06/2020 06:47, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > > when it returns an error code. Thus a pairing decrement is needed on > > the error handling path to keep the counter balanced. > > So you have not mentioned here why you are using _noidle and not _put. > Furthermore, in this patch [0] you are not using _noidle to fix the same > problem in another driver. We should fix this in a consistent manner > across all drivers, otherwise it leads to more confusion. > > Finally, Rafael mentions we should just use _put [0] and so I think we > should follow his recommendation. > > Jon > > [0] https://lkml.org/lkml/2020/5/21/601 "_noidle() is the simplest one and it is sufficient." https://lore.kernel.org/linux-i2c/CAJZ5v0i87NGcy9+kxubScdPDyByr8ypQWcGgBFn+V-wDd69BHQ@xxxxxxxxxxxxxx/ You never know what additional things the other put* variants will start doing in the future... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
