On 24-04-20, 19:11, Andy Shevchenko wrote:
> Under some circumstances, i.e. when test is still running and about to
> time out and user runs, for example,
>
> grep -H . /sys/module/dmatest/parameters/*
>
> the iterations parameter is not respected and test is going on and on until
> user gives
>
> echo 0 > /sys/module/dmatest/parameters/run
>
> This is not what expected.
>
> The history of this bug is interesting. I though that the commit
> 2d88ce76eb98 ("dmatest: add a 'wait' parameter")
> is a culprit, but looking closer to the code I think it simple revealed the
> broken logic from the day one, i.e. in the commit
> 0a2ff57d6fba ("dmaengine: dmatest: add a maximum number of test iterations")
> which adds iterations parameter.
>
> So, to the point, the conditional of checking the thread to be stopped being
> first part of conjunction logic prevents to check iterations. Thus, we have to
> always check both conditions to be able to stop after given iterations.
>
> Since it wasn't visible before second commit appeared, I add a respective
> Fixes tag.
Applied, thanks
--
~Vinod
