RE: [PATCH v2 2/2] dt-bindings: dma: renesas,usb-dmac: convert bindings to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Friday, April 17, 2020 4:38 PM
<snip>
> 
> Hi Shimoda-san,
> 
> 
> On Fri, Apr 17, 2020 at 5:55 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Convert Renesas R-Car USB-DMA Controller bindings documentation
> > to json-schema.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> 
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.yaml
> > @@ -0,0 +1,101 @@
> 
> > +  interrupts:
> > +    minItems: 2
> 
> Don't you need to keep the "maxItems: 2", too?

Oops! I'll fix it.

> > +  interrupt-names:
> > +    minItems: 2
> > +    items:
> > +      - pattern: ch0
> > +      - pattern: ch1
> 
> According to Documentation/devicetree/bindings/example-schema.yaml
> 
>     The description of each element defines the order and implicitly defines
>     the number of reg entries.
> 
> So I think you can drop the minItems.

Thank you for the information. I got it.

> > +  iommus:
> > +    minItems: 2
> 
> + maxItems: 2

I'll fix it.

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux