Re: [PATCH] of_device: removed #include that caused a recursion in included headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hadar,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next tegra/for-next linus/master v5.7-rc1 next-20200413]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200414-032638
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: x86_64-randconfig-h003-20200413 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 8e2daa0c7f27b5d13b11bff68ae3cd42329abd6c)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/clk/mediatek/clk-mt7622-aud.c:153:6: error: implicit declaration of function 'devm_of_platform_populate' [-Werror,-Wimplicit-function-declaration]
           r = devm_of_platform_populate(&pdev->dev);
               ^
   1 error generated.

vim +/devm_of_platform_populate +153 drivers/clk/mediatek/clk-mt7622-aud.c

2fc0a509e4ee85 Sean Wang 2017-10-05  132  
2fc0a509e4ee85 Sean Wang 2017-10-05  133  static int clk_mt7622_audiosys_init(struct platform_device *pdev)
2fc0a509e4ee85 Sean Wang 2017-10-05  134  {
2fc0a509e4ee85 Sean Wang 2017-10-05  135  	struct clk_onecell_data *clk_data;
2fc0a509e4ee85 Sean Wang 2017-10-05  136  	struct device_node *node = pdev->dev.of_node;
2fc0a509e4ee85 Sean Wang 2017-10-05  137  	int r;
2fc0a509e4ee85 Sean Wang 2017-10-05  138  
2fc0a509e4ee85 Sean Wang 2017-10-05  139  	clk_data = mtk_alloc_clk_data(CLK_AUDIO_NR_CLK);
2fc0a509e4ee85 Sean Wang 2017-10-05  140  
2fc0a509e4ee85 Sean Wang 2017-10-05  141  	mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks),
2fc0a509e4ee85 Sean Wang 2017-10-05  142  			       clk_data);
2fc0a509e4ee85 Sean Wang 2017-10-05  143  
2fc0a509e4ee85 Sean Wang 2017-10-05  144  	r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
037b21133e5367 Ryder Lee 2018-03-20  145  	if (r) {
2fc0a509e4ee85 Sean Wang 2017-10-05  146  		dev_err(&pdev->dev,
2fc0a509e4ee85 Sean Wang 2017-10-05  147  			"could not register clock provider: %s: %d\n",
2fc0a509e4ee85 Sean Wang 2017-10-05  148  			pdev->name, r);
2fc0a509e4ee85 Sean Wang 2017-10-05  149  
037b21133e5367 Ryder Lee 2018-03-20  150  		goto err_clk_provider;
037b21133e5367 Ryder Lee 2018-03-20  151  	}
037b21133e5367 Ryder Lee 2018-03-20  152  
037b21133e5367 Ryder Lee 2018-03-20 @153  	r = devm_of_platform_populate(&pdev->dev);
037b21133e5367 Ryder Lee 2018-03-20  154  	if (r)
037b21133e5367 Ryder Lee 2018-03-20  155  		goto err_plat_populate;
037b21133e5367 Ryder Lee 2018-03-20  156  
037b21133e5367 Ryder Lee 2018-03-20  157  	return 0;
037b21133e5367 Ryder Lee 2018-03-20  158  
037b21133e5367 Ryder Lee 2018-03-20  159  err_plat_populate:
037b21133e5367 Ryder Lee 2018-03-20  160  	of_clk_del_provider(node);
037b21133e5367 Ryder Lee 2018-03-20  161  err_clk_provider:
2fc0a509e4ee85 Sean Wang 2017-10-05  162  	return r;
2fc0a509e4ee85 Sean Wang 2017-10-05  163  }
2fc0a509e4ee85 Sean Wang 2017-10-05  164  

:::::: The code at line 153 was first introduced by commit
:::::: 037b21133e5367c833908db0226d77138ba4c5eb clk: mediatek: add devm_of_platform_populate() for MT7622 audsys

:::::: TO: Ryder Lee <ryder.lee@xxxxxxxxxxxx>
:::::: CC: Stephen Boyd <sboyd@xxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux