On 2/25/20 1:14 AM, Vinod Koul wrote:
The driver assigns result of check_vma() to rc and never checks the
result, so remove the assignment
drivers/dma/idxd/cdev.c: In function ‘idxd_cdev_mmap’:
drivers/dma/idxd/cdev.c:136:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
136 | int rc;
| ^~
Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
---
Dave, if you want the result of the check_vma() to be checked, feel free to
send the patch for that
Yes I will send a fix. Mistake from several code merges. Oops.
drivers/dma/idxd/cdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
index 8dfdbe37e381..82b19eed6561 100644
--- a/drivers/dma/idxd/cdev.c
+++ b/drivers/dma/idxd/cdev.c
@@ -133,10 +133,9 @@ static int idxd_cdev_mmap(struct file *filp, struct vm_area_struct *vma)
struct pci_dev *pdev = idxd->pdev;
phys_addr_t base = pci_resource_start(pdev, IDXD_WQ_BAR);
unsigned long pfn;
- int rc;
dev_dbg(&pdev->dev, "%s called\n", __func__);
- rc = check_vma(wq, vma, __func__);
+ check_vma(wq, vma, __func__);
vma->vm_flags |= VM_DONTCOPY;
pfn = (base + idxd_get_wq_portal_full_offset(wq->id,
