Hi Dan, On Mon, Feb 17, 2020 at 3:41 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > The caller is already holding the lock so this will deadlock. > > Fixes: 0b58828c923e ("DMAENGINE: COH 901 318 remove irq counting") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > This is the second double lock bug found using static analysis. The > previous one was commit 627469e4445b ("dmaengine: coh901318: Fix a > double-lock bug"). > > The fact that this has been broken for ten years suggests that no one > has the hardware. Or this only runs CONFIG_SMP=n kernels? This seems to be used in arch/arm/boot/dts/ste-u300.dts only, and CONFIG_ARCH_U300 is a ARCH_MULTI_V5 platform, which looks like it doesn't support SMP? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds