On 2019/12/29 0:54, kbuild test robot wrote: > Hi Zhou, > > I love your patch! Yet something to improve: > > [auto build test ERROR on slave-dma/next] > [also build test ERROR on linus/master v5.5-rc3 next-20191220] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Zhou-Wang/dmaengine-hisilicon-Add-Kunpeng-DMA-engine-support/20191228-195257 > base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git next > config: sh-allmodconfig (attached as .config) > compiler: sh4-linux-gcc (GCC) 7.5.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.5.0 make.cross ARCH=sh > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > All error/warnings (new ones prefixed by >>): > > drivers//dma/hisi_dma.c: In function 'hisi_dma_free_irq_vectors': >>> drivers//dma/hisi_dma.c:132:2: error: implicit declaration of function 'pci_free_irq_vectors'; did you mean 'pci_alloc_irq_vectors'? [-Werror=implicit-function-declaration] > pci_free_irq_vectors(data); > ^~~~~~~~~~~~~~~~~~~~ > pci_alloc_irq_vectors > drivers//dma/hisi_dma.c: At top level: >>> drivers//dma/hisi_dma.c:593:1: warning: data definition has no type or storage class > module_pci_driver(hisi_dma_pci_driver); > ^~~~~~~~~~~~~~~~~ >>> drivers//dma/hisi_dma.c:593:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int] >>> drivers//dma/hisi_dma.c:593:1: warning: parameter names (without types) in function declaration > drivers//dma/hisi_dma.c:587:26: warning: 'hisi_dma_pci_driver' defined but not used [-Wunused-variable] > static struct pci_driver hisi_dma_pci_driver = { > ^~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > vim +132 drivers//dma/hisi_dma.c > > 129 > 130 static void hisi_dma_free_irq_vectors(void *data) > 131 { > > 132 pci_free_irq_vectors(data); > 133 } > 134 > Will add PCI_MSI dependency in Kconfig, like: depends on ARM64 || (COMPILE_TEST && PCI_MSI) Thanks, Zhou > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation >