Re: [PATCH 4/4] dmaengine: Add debugfs entries for PTDMA information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/24/2019 1:35 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> [CAUTION: External Email]
>
> On Tue, Sep 24, 2019 at 07:33:02AM +0000, Mehta, Sanju wrote:
>> +static const struct file_operations pt_debugfs_info_ops = {
>> +     .owner = THIS_MODULE,
>> +     .open = simple_open,
>> +     .read = ptdma_debugfs_info_read,
>> +     .write = NULL,
>> +};
>> +
>> +static const struct file_operations pt_debugfs_queue_ops = {
>> +     .owner = THIS_MODULE,
>> +     .open = simple_open,
>> +     .read = ptdma_debugfs_queue_read,
>> +     .write = ptdma_debugfs_queue_write,
>> +};
>> +
>> +static const struct file_operations pt_debugfs_stats_ops = {
>> +     .owner = THIS_MODULE,
>> +     .open = simple_open,
>> +     .read = ptdma_debugfs_stats_read,
>> +     .write = ptdma_debugfs_stats_write,
>> +};
> Can you use DEFINE_SIMPLE_ATTRIBUTE() here intead of these?
Okay Greg, noted. This will be resolved in next set of patches.
>
> thanks,
>
> greg k-h




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux