On 30-08-19, 11:14, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct stm32_dma_desc {
> ...
> struct stm32_dma_sg_req sg_req[];
> };
>
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> So, replace the following function:
>
> static struct stm32_dma_desc *stm32_dma_alloc_desc(u32 num_sgs)
> {
> return kzalloc(sizeof(struct stm32_dma_desc) +
> sizeof(struct stm32_dma_sg_req) * num_sgs, GFP_NOWAIT);
> }
>
> with:
>
> kzalloc(struct_size(desc, sg_req, num_sgs), GFP_NOWAIT)
>
> This code was detected with the help of Coccinelle.
Applied, thanks
--
~Vinod
