Hi Peter-san,
> From: Peter Ujfalusi, Sent: Wednesday, August 28, 2019 6:39 PM
>
> Hi Shimoda-san,
>
> On 28/08/2019 11.55, Yoshihiro Shimoda wrote:
> > Hi Peter,
> >
> >> From: Peter Ujfalusi, Sent: Wednesday, August 28, 2019 4:25 PM
> >>
> >> On 28/08/2019 9.39, Yoshihiro Shimoda wrote:
> >>> The commit b37e3534ac42 ("dt-bindings: dmaengine: Add YAML schemas
> >>> for the generic DMA bindings") changed the property from
> >>> dma-channel-mask to dma-channel-masks. So, this patch revises it.
> >>>
> >>> Fixes: b37e3534ac42 ("dt-bindings: dmaengine: Add YAML schemas for the generic DMA bindings")
> >>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> >>> ---
> >>> Documentation/devicetree/bindings/dma/dma-common.yaml | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/dma/dma-common.yaml
> >> b/Documentation/devicetree/bindings/dma/dma-common.yaml
> >>> index 0141af0..ed0a49a 100644
> >>> --- a/Documentation/devicetree/bindings/dma/dma-common.yaml
> >>> +++ b/Documentation/devicetree/bindings/dma/dma-common.yaml
> >>> @@ -24,7 +24,7 @@ properties:
> >>> description:
> >>> Used to provide DMA controller specific information.
> >>>
> >>> - dma-channel-masks:
> >>> + dma-channel-mask:
> >>> $ref: /schemas/types.yaml#definitions/uint32
> >>
> >> How this mask supposed to be used for controllers having more than 32
> >> channels (64, 300+)?
> >
> > I found "dma-channels" property as 40 in arch/arm/boot/dts/ste-u300.dts.
> > However, since arch/arm64/boot/dts/hisilicon/hi3660.dtsi already has
> > the dma-channel-mask property, I think we should not change the property name.
>
> I'm not asking it to be changed, I just wondered how I could use this
> generic property for DMA controllers having more channels than u32
> bitfield could describe. An array of multiple u32 to cover the number of
> channels would probably something which can be done, but it would need
> update for the documentation to make sure that it is used consistently.
>
> I'm asking this because of: https://patchwork.kernel.org/patch/11111619/
Oops, I'm sorry for misunderstanding your question.
As you said, I also think that you can use this generic property if we update
the document from uint32 to uint32-array like below:
- $ref: /schemas/types.yaml#definitions/uint32
+ $ref: /schemas/types.yaml#definitions/uint32-array
Best regards,
Yoshihiro Shimoda
> >
> > Best regards,
> > Yoshihiro Shimoda
> >
> >>> description:
> >>> Bitmask of available DMA channels in ascending order that are
> >>>
> >>
> >> - Péter
> >>
> >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> - Péter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
