Hi Vinod, On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote: > > > + if (ret) > > + dev_warn(&pdev->dev, "failed to get firmware name\n"); > > if should have braces! > Applied after fixing braces! checkpatch.pl output after adding braces: WARNING: braces {} are not necessary for single statement blocks #102: FILE: drivers/dma/imx-sdma.c:2165: + if (ret) { + dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); + } total: 0 errors, 1 warnings, 61 lines checked