On Fri, Jun 21, 2019 at 10:1:1, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Fri, Jun 21, 2019 at 10:53 AM Gustavo Pimentel > <Gustavo.Pimentel@xxxxxxxxxxxx> wrote: > > > > > > > static struct dentry *base_dir; > > > static struct dw_edma *dw; > > > -static struct dw_edma_v0_regs *regs; > > > +static struct dw_edma_v0_regs __iomem *regs; > > > > Shouldn't the __iomem be next to dw_edma_v0_regs instead of the variable > > name? I saw other drivers putting the __iomem next to the variable type, > > therefore I assume it's the typical coding style. > > Yes, that seems more common indeed. Do you want to fix up > both patches yourself when you apply them or should I send a new version? If you could do that, it will be great. Thanks. > > Arnd
