On 22-05-19, 03:21, Peng Ma wrote:
> When an error occurs we should clean the error register then to return
The patch title is supposed to tell us about the change. "Add
improvement: is a very generic term!
I have change title to "Continue to clear register on error" and applied
>
> Signed-off-by: Peng Ma <peng.ma@xxxxxxx>
> ---
> changed for V3:
> - no changed.
>
> drivers/dma/fsl-qdma.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c
> index da8fdf5..8e341c0 100644
> --- a/drivers/dma/fsl-qdma.c
> +++ b/drivers/dma/fsl-qdma.c
> @@ -703,10 +703,8 @@ static irqreturn_t fsl_qdma_error_handler(int irq, void *dev_id)
>
> intr = qdma_readl(fsl_qdma, status + FSL_QDMA_DEDR);
>
> - if (intr) {
> + if (intr)
> dev_err(fsl_qdma->dma_dev.dev, "DMA transaction error!\n");
> - return IRQ_NONE;
> - }
>
> qdma_writel(fsl_qdma, FSL_QDMA_DEDR_CLEAR, status + FSL_QDMA_DEDR);
> return IRQ_HANDLED;
> --
> 1.7.1
--
~Vinod
