Re: [PATCH v1 4/6] dmaengine: fsl-edma: add i.mx7ulp edma2 version support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-05-27 at 06:34 +0000, Vinod Koul wrote:
> On 10-05-19, 10:14, Robin Gong wrote:
> > 
> >  
> > +	if (of_device_is_compatible(np, "fsl,imx7ulp-edma")) {
> > +		fsl_edma->dmamux_nr = 1;
> > +		fsl_edma->version = v3;
> well this is not really scalable, we will keep adding versions and
> compatible and expanding this check. So it would make sense to create
> a
> driver data table which can be set for compatible and we use those
> values and avoid these runtime checks for compatible.
> 
> Btw the binding documentation should precede the code usage, so this
> patch should come after that
> 
Okay, will update in v2.




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux