On Mon, 2019-05-27 at 12:07 +0530, Vinod Koul wrote: > [External] > > > On 21-05-19, 17:14, Alexandru Ardelean wrote: > > The AXI HDL cores provided for Analog Devices reference designs all share > > some common base registers (e.g. version register at address 0x00). > > > > To reduce duplication for this, a common header is added to define these > > registers as well as bitfields & macros to work with these registers. > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > --- > > include/linux/fpga/adi-axi-common.h | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > create mode 100644 include/linux/fpga/adi-axi-common.h > > > > diff --git a/include/linux/fpga/adi-axi-common.h b/include/linux/fpga/adi-axi-common.h > > new file mode 100644 > > index 000000000000..7966c89561b1 > > --- /dev/null > > +++ b/include/linux/fpga/adi-axi-common.h > > @@ -0,0 +1,19 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > For headers this is not the style to be used. > See Documentation/process/license-rules.rst > > C source: // SPDX-License-Identifier: <SPDX License Expression> > C header: /* SPDX-License-Identifier: <SPDX License Expression> */ > Ack. Will re-spin. > > +/* > > + * Analog Devices AXI common registers & definitions > > + * > > + * Copyright 2019 Analog Devices Inc. > > + * > > + * https://wiki.analog.com/resources/fpga/docs/axi_ip > > + * https://wiki.analog.com/resources/fpga/docs/hdl/regmap > > + */ > > + > > +#ifndef ADI_AXI_COMMON_H_ > > +#define ADI_AXI_COMMON_H_ > > + > > +#define ADI_AXI_REG_VERSION 0x0000 > > + > > +#define ADI_AXI_PCORE_VER(major, minor, patch) \ > > + (((major) << 16) | ((minor) << 8) | (patch)) > > + > > +#endif /* ADI_AXI_COMMON_H_ */ > > -- > > 2.17.1 > > -- > ~Vinod
