On 16-05-19, 09:11, Dave Jiang wrote: > > > On 5/9/19 4:37 PM, Dave Jiang wrote: > > When ioat_free_chan_resources() gets called, ioat_stop() is called without > > chan->cleanup_lock. ioat_stop modifies IOAT_RUN bit. It needs to be > > protected by cleanup_lock. Also, in the __cleanup() path, if IOAT_RUN is > > cleared, we should not touch the timer again. We observed that the timer > > routine was run after timer was deleted. > > > > Fixes: 3372de5813e ("dmaengine: ioatdma: removal of dma_v3.c and relevant ioat3 > > references") > > > > Reported-by: Fan Du <fan.du@xxxxxxxxx> > > Tested-by: Fan Du <fan.du@xxxxxxxxx> > > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> > > Vinod, can you hold off on this please? There may be more changes. Thanks. Okay dropped -- ~Vinod