Re: [PATCH] dmaengine: rcar-dmac: Update copyright information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 26, 2019 at 05:23:43PM +0530, Vinod Koul wrote:
> On 25-04-19, 03:52, Yoshihiro Shimoda wrote:
> > Hi Geert-san,
> > 
> > > From: Geert Uytterhoeven, Sent: Wednesday, April 24, 2019 9:22 PM
> > > 
> > > Hi Niklas, Shimoda-san,
> > > 
> > > On Thu, Apr 11, 2019 at 5:18 PM Niklas Söderlund
> > > <niklas.soderlund@xxxxxxxxxxxx> wrote:
> > > > On 2019-04-11 10:49:37 +0200, Simon Horman wrote:
> > > > > On Wed, Apr 10, 2019 at 08:26:57PM +0200, Niklas Söderlund wrote:
> > > > > Not strictly related, but is it appropriate to:
> > > > >
> > > > > 1. Move this driver and drivers/dma/sh/usb-dmac.c to drivers/dma/renesas/
> > > 
> > > That may make sense...
> > > 
> > > > > 2. Remove drivers/dma/sh/sudmac.c which appears unused
> > > >
> > > > I let someone with a better grasp of history answer this one. From my
> > > > side removing drivers which are unused seems like a good idea :-)
> > > 
> > > There seem to be some (half-baked?) interaction between sudmac.c and
> > > drivers/usb/gadget/udc/r8a66597-udc.c and drivers/usb/renesas_usbhs/fifo.c.
> > > These don't seem to be used at all on Renesas ARM platforms, but
> > > CONFIG_USB_R8A66597_HCD is enabled in shmobile_defconfig and
> > > multi_v7_defconfig?
> > > 
> > > Shimoda-san: can you please enlighten us?
> > > Thanks!
> > 
> > Sure.
> > 
> > - SH4A / sh7757 has SUDMAC. (any other Renesas ARM platforms don't have it).
> >  # sh7757 is not public product though...
> > - At first, I added this SUDMAC support into r8a66597-udc.
> > - But, our direction is changed by some reason. So, we use renesas_usbhs driver anyway.
> > - The renesas_usbhs supports dmaengine, so I added dma/sh/sudmac driver.
> > - However, for some reasons (maybe I'm busy for other projects?),
> >   I didn't add using the sudmac support into arch/sh/kernel/cpu/sh4a/setup-sh7757.c.
> > - So, no one uses both r8a66597-udc and sudmac now.
> > 
> > From 2013 (added the sudmac driver) to now, since no one integrated the sudmac for sh7757,
> > I think we can remove the driver.
> 
> And where is the removal patch :)

Sorry for the delay, I have just posted

[PATCH] dmaengine: sudmac: remove unused driver


Shimoda-san, can we go further and also:

1. Remove the r8a66597-udc driver, which also seems unused
2. Remove (minimal) sudmac integration from usbhs ?



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux