On Mon, 29 Apr 2019 at 22:10, Vinod Koul <vkoul@xxxxxxxxxx> wrote: > > On 29-04-19, 20:11, Baolin Wang wrote: > > On Mon, 29 Apr 2019 at 20:01, Vinod Koul <vkoul@xxxxxxxxxx> wrote: > > > On 15-04-19, 20:15, Baolin Wang wrote: > > > > > @@ -429,6 +433,9 @@ static int sprd_dma_set_2stage_config(struct sprd_dma_chn *schan) > > > > val = chn & SPRD_DMA_GLB_SRC_CHN_MASK; > > > > val |= BIT(schan->trg_mode - 1) << SPRD_DMA_GLB_TRG_OFFSET; > > > > val |= SPRD_DMA_GLB_2STAGE_EN; > > > > + if (schan->int_type != SPRD_DMA_NO_INT) > > > > > > Who configure int_type? > > > > The int_type is configured through the flags of > > sprd_dma_prep_slave_sg() by users, see: > > https://elixir.bootlin.com/linux/v5.1-rc6/source/include/linux/dma/sprd-dma.h#L9 > > Please use DMA_PREP_INTERRUPT flag instead! We can not use DMA_PREP_INTERRUPT flag, since we have some Spreadtrum specific DMA interrupt flags configured by users, which I think we have made a consensus before. See: https://elixir.bootlin.com/linux/v5.1-rc6/source/include/linux/dma/sprd-dma.h#L105 -- Baolin Wang Best Regards
