Hello Maxime Ripard,
This is a semi-automatic email about new static checker warnings.
The patch bcd1b0b9015b: "dmaengine: pl08x: Split device_control" from
Nov 17, 2014, leads to the following Smatch complaint:
drivers/dma/amba-pl08x.c:2251 pl08x_resume()
error: we previously assumed 'plchan->phychan' could be null (see line 2246)
drivers/dma/amba-pl08x.c
2245 spin_lock_irqsave(&plchan->vc.lock, flags);
2246 if (!plchan->phychan && !plchan->at) {
^^
Should this be || ?
2247 spin_unlock_irqrestore(&plchan->vc.lock, flags);
2248 return 0;
2249 }
2250
2251 pl08x_resume_phy_chan(plchan->phychan);
^^^^^^^^^^^^^^^
Dereferenced inside the function.
2252 plchan->state = PL08X_CHAN_RUNNING;
2253
regards,
dan carpenter
