On 27-02-19, 08:12, Ardelean, Alexandru wrote: > On Tue, 2019-02-26 at 10:52 +0200, Alexandru Ardelean wrote: > > The `copy_align` property is a generic property that describes alignment > > for DMA memcpy & sg ops. > > It serves mostly an informational purpose, and can be used in DMA tests, > > to > > pass the info to know what alignment to expect. > > > > build bot said this doesn't compile. > I think this patch needs to come later after some more updates have been > pushed for this driver. Well build bot has no idea about that (like me), so better to put them in a series and send (that way bot and me know which should come first) > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > --- > > > > Changelog v1 -> v2: > > * re-applied & moved the `copy_align` assignment; apparently it was > > conflicting with another patch from another series > > > > drivers/dma/dma-axi-dmac.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c > > index ffc0adc2f6ce..5ec223ff7e1a 100644 > > --- a/drivers/dma/dma-axi-dmac.c > > +++ b/drivers/dma/dma-axi-dmac.c > > @@ -666,6 +666,7 @@ static int axi_dmac_probe(struct platform_device > > *pdev) > > dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); > > dma_dev->directions = BIT(dmac->chan.direction); > > dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; > > + dma_dev->copy_align = (dmac->chan.address_align_mask + 1); > > INIT_LIST_HEAD(&dma_dev->channels); > > > > dmac->chan.vchan.desc_free = axi_dmac_desc_free; -- ~Vinod
