On 23-01-19, 08:42, Angus Ainslie wrote: > On 2019-01-23 08:31, Lucas Stach wrote: > > Hi Angus, > > > > Am Mittwoch, den 23.01.2019, 08:23 -0700 schrieb Angus Ainslie (Purism): > > > On i.mx8mq, there are two sdma instances, and the common dma framework > > > will get a channel dynamically from any available sdma instance > > > whether > > > it's the first sdma device or the second sdma device. Some IPs like > > > SAI only work with sdma2 not sdma1. To make sure the sdma channel is > > > from > > > the correct sdma device, use an index to match. > > > > > > Based on MLK-16104-2 by Robin Gong <yibin.gong@xxxxxxx> > > > > This relies on the probe order of the devices (which should be treated > > as random) for the match to find the right device. This is not > > acceptable upstream. > > > > The DT "dmas" property already specifies the correct SDMA device to use > > for a consumer, so the filter function should really match the OF node > > of the SDMA device with the node specified in the dmas phandle in order > > to pick the right SDMA engine. > > > > Thanks Lucas, I'll fix it for rev 4 And fix the subsystem name, it is 'dmaengine: ...' not 'dma: ...'. git log of the subsystem should give you good clue of the tags to be used.. Thanks -- ~Vinod
