On Fri, Dec 28, 2018 at 02:26:00PM +0100, Stefan Wahren wrote: > > Lukas Wunner <lukas@xxxxxxxxx> hat am 22. Dezember 2018 um 08:28 geschrieben: > > The BCM2835 DMA driver deletes a channel from a list upon termination > > without having added it to a list first. Moreover that operation is > > protected by a spinlock which isn't taken anywhere else. These appear > > to be remnants of an older version of the driver which accidentally > > got mainlined. Remove the dead code. > > > > While at it remove an outdated comment claiming the driver only supports > > cyclic transactions. The driver has been supporting other transaction > > types for more than two years. > > the fact that your mixing two different changes in one patch results > in a very general subject. In so far as a code comment can be considered code, removal of an obsolete code comment can be referred to as removal of dead code. So the subject seems pertinent to everything contained in this patch from my point of view. > Please split this up and give them more specific subject lines. Frankly I don't consider removal of a 2 line code comment worthy a commit of it's own, so if this is indeed a concern, I'd rather drop it from the patch and leave the obsolete code comment in the file for removal at some other date. Thanks, Lukas
