On 12-12-18, 17:00, Bjorn Helgaas wrote: > On Wed, Dec 12, 2018 at 12:13:21PM +0100, Gustavo Pimentel wrote: > > Add Synopsys eDMA IP core driver to kernel. > > > > This core driver, initializes and configures the eDMA IP using vma-helpers > > functions and dma-engine subsystem. > > > > Also creates an abstration layer through callbacks allowing different > > registers mappings in the future, organized in to versions. > > > > This driver can be compile as built-in or external module in kernel. > > > > To enable this driver just select DW_EDMA option in kernel configuration, > > however it requires and selects automatically DMA_ENGINE and > > DMA_VIRTUAL_CHANNELS option too. > > > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx> > > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > > Cc: Eugeniy Paltsev <paltsev@xxxxxxxxxxxx> > > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Cc: Joao Pinto <jpinto@xxxxxxxxxxxx> > > > --- /dev/null > > +++ b/drivers/dma/dw-edma/dw-edma-core.c > > @@ -0,0 +1,925 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +// Copyright (c) 2018 Synopsys, Inc. and/or its affiliates. > > +// Synopsys DesignWare eDMA core driver > > The SPDX line in .c files needs the // comment for some obscure reason > I can't remember, but based on the other drivers/dma/*.c files, it > looks like the convention is the usual /* .. */ comments for the rest. > > I think the SPDX line is /* */ in .h files though. The rules are > under Documentation/ somewhere. Yes and documented in Documentation/process/license-rules.rst "license identifier syntax" section -- ~Vinod
