Re: [PATCH v4 0/2] dmaengine: add UniPhier MIO DMAC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25-11-18, 22:53, Masahiro Yamada wrote:
> On Sat, Nov 24, 2018 at 11:16 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> >
> > On 12-10-18, 01:41, Masahiro Yamada wrote:
> > > 1/2: DT-binding
> > > 2/2: driver
> >
> > Applied this series, thanks
> 
> 
> Thanks.
> 
> 
> > While building I noticed that we get few warns when compiling with
> > C=1, I would prefer you fix them. Please send fixes on top of the
> > applied patches.
> 
> My code is fine.

Lets see..

> If you are talking about the following, your sparse is too old.
> Upgrade your sparse.

Not really!!

$ sparse --version
0.5.2

.. is the last released version!

Do you use from git?

> ./include/linux/overflow.h:285:13: error: undefined identifier
> '__builtin_mul_overflow'
> ./include/linux/overflow.h:285:13: error: incorrect type in conditional
> ./include/linux/overflow.h:285:13:    got void
> ./include/linux/overflow.h:287:13: error: undefined identifier
> '__builtin_add_overflow'
> ./include/linux/overflow.h:287:13: error: incorrect type in conditional
> ./include/linux/overflow.h:287:13:    got void
> ./include/linux/overflow.h:285:13: warning: call with no type!
> ./include/linux/overflow.h:287:13: warning: call with no type!

and I was also talking about:

arch/arm64/include/asm/sysreg.h:471:42: warning: constant 0xffffffffffffffff is so big it is unsigned long
arch/arm64/include/asm/sysreg.h:512:42: warning: constant 0xffffffffffffffff is so big it is unsigned long
include/linux/slab.h:332:43: warning: dubious: x & !y

-- 
~Vinod



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux