Hello, On Sat, Nov 24, 2018 at 05:48:23PM +0000, Russell King - ARM Linux wrote: > Hmm, there's more questionable stuff in this driver, and the gadget > layer. [...] > So, whatever way I look at this, the code in the removal path both > in omap_udc and the gadget removal code higher up looks very wrong > and broken to me. Yes, week ago I saw omap_udc crashing on both probe failure and module removal and sent some fixes for the most obvious failures (see https://marc.info/?l=linux-usb&m=154258778316932&w=2). Is there any good driver that uses usb_add_gadget_udc_release() correctly? Looking at fsl_qe_udc.c and fsl_udc_core.c they should also crash if usb_add_gadget_udc_release() fails. A.
