On Wed, 21 Nov 2018 16:13:23 +0000 Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote: > Add some trace-points to the driver to allow for debuging via the > trace pipe. > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> >From a tracing perspective I see nothing wrong with this patch. Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> -- Steve > --- > Fixes since v1: > - take copy of dmachan name instead of pointer to device > > Fixes since v2: > - finish off Steven's review comments > - fix saving the dma channel name > - use txstate as argument to trace_tegra_dma_tx_status() > - fix type of dma_cookie to dma_cookie_t > > Cc: Ingo Molnar <mingo@xxxxxxxxxx> (maintainer:TRACING) > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx> (maintainer:TRACING)