Hi Vinod, On Tue, Oct 09, 2018 at 01:00:01PM +0530, Vinod wrote: > On 09-10-18, 09:22, Krzysztof Kozlowski wrote: > > On Sun, 7 Oct 2018 at 16:15, Vinod Koul <vkoul@xxxxxxxxxx> wrote: > > > > > > dma_slave_config direction was marked as deprecated quite some > > > time back, remove the usage from this driver so that the field > > > can be removed > > > > > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > > --- > > > CC: Angelo Dureghello <angelo@xxxxxxxx> > > > CC: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > > > > > Angelo, Krzysztof, > > > > > > I have rebased this against the latest fsl-edma changes, can you > > > please verify this and let me know, thnx > > > > I applied it on top of linux next (20181008) and compilation fails: > > > > ../drivers/i2c/busses/i2c-imx.c: In function ‘i2c_imx_dma_request’: > > ../drivers/i2c/busses/i2c-imx.c:298:13: error: ‘struct > > dma_slave_config’ has no member named ‘direction’ > > dma_sconfig.direction = DMA_MEM_TO_DEV; > > ^ > > ../drivers/i2c/busses/i2c-imx.c:315:13: error: ‘struct > > dma_slave_config’ has no member named ‘direction’ > > dma_sconfig.direction = DMA_DEV_TO_MEM; > > ^ > > > > ../drivers/mmc/host/mmci.c: In function ‘__mmci_dma_prep_data’: > > ../drivers/mmc/host/mmci.c:578:7: error: ‘struct dma_slave_config’ has > > no member named ‘direction’ > > conf.direction = DMA_DEV_TO_MEM; > > ^ > > ../drivers/mmc/host/mmci.c:581:7: error: ‘struct dma_slave_config’ has > > no member named ‘direction’ > > conf.direction = DMA_MEM_TO_DEV; > > ^ > > ../drivers/mmc/host/mmci.c:604:14: error: ‘struct dma_slave_config’ > > has no member named ‘direction’ > > conf.direction, flags); > > ^ > > > > Am I missing some dependencies? > > Nope, the dmaengine.h change I used to verify removing off all instances > has crept up in this, sorry for that. > > Can you remove the deletion and try again, I will post v3 as well > Thanks for the patch, looks like i left this out from my previous set. I re-added direction to struct dma_slave_config and tested the patch on both stmark2 (ColdFire mcf5441x) and Colibri VF50 with Krzysztof Kozlowski proceq_vf_bck_defconfig + vf500-colibri-eval-v3.dtb. At least for ColdFire DSPI + DMA, and console + DMA on Colibri, all seems to work properly. Tested-by: Angelo Dureghello <angelo@xxxxxxxx> > -- > ~Vinod Regards, Angelo
