Re: [PATCH 02/12] dmaengine: bcm2835: remove dma_slave_config direction usage

[Scott Branden <scott.branden@xxxxxxxxxxxx>]

On 18-09-11 01:35 AM, Vinod Koul wrote:
> dma_slave_config direction was marked as deprecated quite some
> time back, remove the usage from this driver so that the field
> can be removed
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
Acked-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> ---
> CC: Ray Jui <rjui@xxxxxxxxxxxx>
> CC: Scott Branden <sbranden@xxxxxxxxxxxx>
>
>   drivers/dma/bcm2835-dma.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 847f84a41a69..cad55ab80d41 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -778,14 +778,6 @@ static int bcm2835_dma_slave_config(struct dma_chan *chan,
>   {
>   	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
>   
> -	if ((cfg->direction == DMA_DEV_TO_MEM &&
> -	     cfg->src_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||
> -	    (cfg->direction == DMA_MEM_TO_DEV &&
> -	     cfg->dst_addr_width != DMA_SLAVE_BUSWIDTH_4_BYTES) ||
> -	    !is_slave_direction(cfg->direction)) {
> -		return -EINVAL;
> -	}
> -
>   	c->cfg = *cfg;
>   
>   	return 0;