On 06.08.2018 10:09, Krzysztof Kozlowski wrote: > On 3 August 2018 at 21:32, Angelo Dureghello <angelo@xxxxxxxx> wrote: >> This patch adds support for ColdFire mcf5441x-family edma >> module. >> >> The ColdFire edma module is slightly different from fsl-edma, >> so a new driver is added. But most of the code is common >> between fsl-edma and mcf-edma so it has been collected into a >> separate common module fsl-edma-common (patch 1/3). >> >> Signed-off-by: Angelo Dureghello <angelo@xxxxxxxx> [...] >> diff --git a/include/linux/platform_data/dma-mcf-edma.h b/include/linux/platform_data/dma-mcf-edma.h >> new file mode 100644 >> index 000000000000..9a1819acb28f >> --- /dev/null >> +++ b/include/linux/platform_data/dma-mcf-edma.h >> @@ -0,0 +1,38 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Freescale eDMA platform data, ColdFire SoC's family. >> + * >> + * Copyright (c) 2017 Angelo Dureghello <angelo@xxxxxxxx> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> + >> +#ifndef __MACH_MCF_EDMA_H__ >> +#define __MACH_MCF_EDMA_H__ > > The guard should rather match current location, e.g. > __LINUX_PLATFORM_DATA_MCF_EDMA_H__ > > Tested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > So this revision fixed the issue we had seen with the previous version? Do we know what it was exactly? -- Stefan -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html