Re: [PATCH v6 1/2] dmaengine: fsl-edma: extract common fsl-edma code (no changes in behavior intended)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinod,

many thanks !

On Tue, Jul 03, 2018 at 11:19:25AM +0530, Vinod wrote:
> On 01-07-18, 18:33, Angelo Dureghello wrote:
> > This patch adds a new fsl-edma-common module to allow new
> > mcf-edma module code to use most of the fsl-edma code.
> > 
> > Due to some differences between ColdFire edma (64 channels) and
> > fsl-edma (32 channels), as register set offsets and some other
> > points as the different interrupt organization and other minor
> > things, a common module can collect most of the code for both
> > 32 and 64 channel edma module versions.
> 
> I have applied these, thanks.
> 
> While applying I saw a trailing whitespace error, have fixed that up as
> below.
> 
Strange checkpatch.pl is not signalling it .. 

> Also, I saw sparse complain a lot, care to fix those too?
> 

Sure. Can send a new version soon.

Regards,
Angelo

> -->8----
> 
> commit 15efb0b488596a929bc00ce23aeb746ee6a7c14d
> Author: Vinod Koul <vkoul@xxxxxxxxxx>
> Date:   Tue Jul 3 11:16:46 2018 +0530
> 
>     dmaengine: fsl-edma: fix trailing whitespace
> 
>     Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> 
> diff --git a/drivers/dma/fsl-edma-common.h b/drivers/dma/fsl-edma-common.h
> index e87c2bec882b..8e3c609c62fa 100644
> --- a/drivers/dma/fsl-edma-common.h
> +++ b/drivers/dma/fsl-edma-common.h
> @@ -159,4 +159,3 @@ int fsl_edma_terminate_all(struct dma_chan *chan);
>  void fsl_edma_issue_pending(struct dma_chan *chan);
>  
>  #endif /* _FSL_EDMA_COMMON_H_ */
> -
> 
> -- 
> ~Vinod
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux