Re: [PATCH 1/3] dmaengine: imx-sdma: Switch to SPDX identifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21-05-18, 23:53, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
>  drivers/dma/imx-sdma.c | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index ccd03c3..f0779926 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1,21 +1,14 @@
> -/*
> - * drivers/dma/imx-sdma.c
> - *
> - * This file contains a driver for the Freescale Smart DMA engine
> - *
> - * Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@xxxxxxxxxxxxxx>
> - *
> - * Based on code from Freescale:
> - *
> - * Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.
> - *
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
> - *
> - * http://www.opensource.org/licenses/gpl-license.html
> - * http://www.gnu.org/copyleft/gpl.html
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// drivers/dma/imx-sdma.c
> +//
> +// This file contains a driver for the Freescale Smart DMA engine
> +//
> +// Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@xxxxxxxxxxxxxx>
> +//
> +// Based on code from Freescale:
> +//
> +// Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.

Are you sure putting everything thru c99 style is apt. I have been told that we
should:

// SPDX-License-Identifier: GPL-2.0+
// Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@xxxxxxxxxxxxxx>

/*
 * rest of the comments you would like
 */

essentially SPDX tag and copyright should be c99 so that tools can parse, rest
information can be in regular linux comment style

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux