On Thu, Apr 19, 2018 at 10:00:49AM +0800, Baolin Wang wrote: > +/* > + * struct sprd_dma_config - DMA configuration structure > + * @src_addr: the physical address where DMA slave data should be read > + * @dst_addr: the physical address where DMA slave data should be written > + * @fragment_len: specify one fragment transfer length > + * @block_len: specify one block transfer length > + * @transcation_len: specify one transcation transfer length > + * @src_step: source transfer step > + * @dst_step: destination transfer step > + * @src_datawidth: source transfer data width > + * @dst_datawidth: destination transfer data width > + * @wrap_ptr: wrap pointer address, once the transfer address reaches the > + * 'wrap_ptr', the next transfer address will jump to the 'wrap_to' address. > + * @wrap_to: wrap jump to address > + * @req_mode: specify the DMA request mode > + * @int_mode: specify the DMA interrupt type > + * @slave_id: slave channel requester id > + */ > +struct sprd_dma_config { can you please not duplicate the dma_slave_config here. If you want to save your own values then please embed dma_slave_config here -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html