Thanks for you, Shunyong. Best Regards, Wen He > -----Original Message----- > From: dmaengine-owner@xxxxxxxxxxxxxxx > [mailto:dmaengine-owner@xxxxxxxxxxxxxxx] On Behalf Of Adam Wallis > Sent: 2018年1月23日 22:32 > To: Yang Shunyong <shunyong.yang@xxxxxxxxxxxxxxxx>; > vinod.koul@xxxxxxxxx > Cc: dan.j.williams@xxxxxxxxx; yu.zheng@xxxxxxxxxxxxxxxx; > dmaengine@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Graham Moore > <graham.moore@xxxxxxxxxxxxxxx>; okaya@xxxxxxxxxxxxxx >> Sinan Kaya > <okaya@xxxxxxxxxxxxxx> > Subject: Re: [PATCH] dmaengine: dmatest: fix container_of member in > dmatest_callback > > On 1/22/2018 2:28 AM, Yang Shunyong wrote: > > The type of arg passed to dmatest_callback is struct dmatest_done. > > It refers to test_done in struct dmatest_thread, not done_wait. > > > > Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...") > > Signed-off-by: Yang Shunyong <shunyong.yang@xxxxxxxxxxxxxxxx> > > --- > > drivers/dma/dmatest.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index > > ec5f9d2bc820..906e85d6dedc 100644 > > --- a/drivers/dma/dmatest.c > > +++ b/drivers/dma/dmatest.c > > @@ -355,7 +355,7 @@ static void dmatest_callback(void *arg) { > > struct dmatest_done *done = arg; > > struct dmatest_thread *thread = > > - container_of(arg, struct dmatest_thread, done_wait); > > + container_of(arg, struct dmatest_thread, test_done); > > if (!thread->done) { > > done->done = true; > > wake_up_all(done->wait); > > > Thanks for the catch > > Acked-by: Adam Wallis <awallis@xxxxxxxxxxxxxx> > -- > Adam Wallis > Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, > Inc. > Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux > Foundation Collaborative Project. > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in the > body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger. > kernel.org%2Fmajordomo-info.html&data=02%7C01%7Cwen.he_1%40nxp.co > m%7C88161568a7fd4349149b08d5626e1661%7C686ea1d3bc2b4c6fa92cd9 > 9c5c301635%7C0%7C0%7C636523147354196622&sdata=txItgvD3P%2FrQq > MSmpZlTY1rA1yUeWxMHTlELO5vwy84%3D&reserved=0 ��.n��������+%������w��{.n��������)�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
