On Sun, 2018-02-04 at 08:18 +0100, Rafael J. Wysocki wrote: > On Thu, Feb 1, 2018 at 9:45 PM, Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, 2018-02-01 at 22:40 +0200, Andy Shevchenko wrote: > > > On Thu, 2018-02-01 at 15:32 -0500, Sinan Kaya wrote: > > > > On 2/1/2018 3:20 PM, Andy Shevchenko wrote: > > > > > When __acpi_match_device() is called it would be possible to > > > > > have > > > > > ACPI ID table a MULL pointer. To avoid potential dereference, > > > > > > > > NULL > > > > > > Thanks, will fix later. > > > > > > > Why not bail out here immediately if ids is null? > > > > > > Because of the code which wasn't in context of this patch. > > > > > > See also patch 1 in the series. > > > > > > It's about how acpi_driver_match_device() uses it. > > > > Btw, it makes device_get_match_data() to work properly on PRP0001 > > kind > > of devices. > > Maybe combine this one with the [1/6] then, it would make it somewhat > easier to follow what's going on. Sure, I will fold in. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
