On 1/4/2018 5:45 PM, Rob Herring wrote: > The hidma driver open codes populating address and IRQ resources from DT. > We have standard functions of_address_to_resource and of_irq_to_resource > for this, so use them instead. > > The DT binding states each child should have 2 addresses and 1 IRQ, so we > can simplify the logic and do a fixed size resource allocation. Using the > standard of_address_to_resource will also do any address translation which > was missing. > > Cc: Andy Gross <andy.gross@xxxxxxxxxx> > Cc: David Brown <david.brown@xxxxxxxxxx> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > Cc: Vinod Koul <vinod.koul@xxxxxxxxx> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > Cc: linux-soc@xxxxxxxxxxxxxxx > Cc: dmaengine@xxxxxxxxxxxxxxx > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > drivers/dma/qcom/hidma_mgmt.c | 61 +++++++++++-------------------------------- > 1 file changed, 15 insertions(+), 46 deletions(-) Thanks, this certainly looks cleaner. Mine was mostly copy/paste from other examples. Reviewed-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx> -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
