Re: [V2] dmaengine: fsl-qdma: add NXP Layerscape qDMA engine driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Wen-He/dmaengine-fsl-qdma-add-NXP-Layerscape-qDMA-engine-driver-support/20171225-232227
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All errors (new ones prefixed by >>):

   In file included from drivers/dma/fsl-qdma.c:27:0:
   drivers/dma/fsldma.h: In function 'in_be64':
>> drivers/dma/fsldma.h:202:15: error: implicit declaration of function 'in_be32'; did you mean 'in_be64'? [-Werror=implicit-function-declaration]
     return ((u64)in_be32((u32 __iomem *)addr) << 32) |
                  ^~~~~~~
                  in_be64
   drivers/dma/fsldma.h: In function 'out_be64':
>> drivers/dma/fsldma.h:208:2: error: implicit declaration of function 'out_be32'; did you mean 'out_be64'? [-Werror=implicit-function-declaration]
     out_be32((u32 __iomem *)addr, val >> 32);
     ^~~~~~~~
     out_be64
   drivers/dma/fsldma.h: In function 'in_le64':
>> drivers/dma/fsldma.h:215:15: error: implicit declaration of function 'in_le32'; did you mean 'in_le64'? [-Werror=implicit-function-declaration]
     return ((u64)in_le32((u32 __iomem *)addr + 1) << 32) |
                  ^~~~~~~
                  in_le64
   drivers/dma/fsldma.h: In function 'out_le64':
>> drivers/dma/fsldma.h:221:2: error: implicit declaration of function 'out_le32'; did you mean 'out_le64'? [-Werror=implicit-function-declaration]
     out_le32((u32 __iomem *)addr + 1, val >> 32);
     ^~~~~~~~
     out_le64
   drivers/dma/fsl-qdma.c: In function 'qdma_readl':
>> drivers/dma/fsl-qdma.c:275:9: error: implicit declaration of function 'FSL_DMA_IN'; did you mean 'FSL_DMA_SNEN'? [-Werror=implicit-function-declaration]
     return FSL_DMA_IN(qdma, addr, 32);
            ^~~~~~~~~~
            FSL_DMA_SNEN
   drivers/dma/fsl-qdma.c: In function 'qdma_writel':
>> drivers/dma/fsl-qdma.c:281:2: error: implicit declaration of function 'FSL_DMA_OUT'; did you mean 'FSL_DMA_EOL'? [-Werror=implicit-function-declaration]
     FSL_DMA_OUT(qdma, addr, val, 32);
     ^~~~~~~~~~~
     FSL_DMA_EOL
   In file included from drivers/dma/fsl-qdma.c:27:0:
   At top level:
   drivers/dma/fsldma.h:219:13: warning: 'out_le64' defined but not used [-Wunused-function]
    static void out_le64(u64 __iomem *addr, u64 val)
                ^~~~~~~~
   drivers/dma/fsldma.h:213:12: warning: 'in_le64' defined but not used [-Wunused-function]
    static u64 in_le64(const u64 __iomem *addr)
               ^~~~~~~
   drivers/dma/fsldma.h:206:13: warning: 'out_be64' defined but not used [-Wunused-function]
    static void out_be64(u64 __iomem *addr, u64 val)
                ^~~~~~~~
   drivers/dma/fsldma.h:200:12: warning: 'in_be64' defined but not used [-Wunused-function]
    static u64 in_be64(const u64 __iomem *addr)
               ^~~~~~~
   cc1: some warnings being treated as errors

vim +202 drivers/dma/fsldma.h

173acc7c Zhang Wei 2008-03-01  198  
173acc7c Zhang Wei 2008-03-01  199  #ifndef __powerpc64__
173acc7c Zhang Wei 2008-03-01  200  static u64 in_be64(const u64 __iomem *addr)
173acc7c Zhang Wei 2008-03-01  201  {
a4e6d5d3 Al Viro   2008-03-29 @202  	return ((u64)in_be32((u32 __iomem *)addr) << 32) |
a4e6d5d3 Al Viro   2008-03-29  203  		(in_be32((u32 __iomem *)addr + 1));
173acc7c Zhang Wei 2008-03-01  204  }
173acc7c Zhang Wei 2008-03-01  205  
173acc7c Zhang Wei 2008-03-01  206  static void out_be64(u64 __iomem *addr, u64 val)
173acc7c Zhang Wei 2008-03-01  207  {
a4e6d5d3 Al Viro   2008-03-29 @208  	out_be32((u32 __iomem *)addr, val >> 32);
a4e6d5d3 Al Viro   2008-03-29  209  	out_be32((u32 __iomem *)addr + 1, (u32)val);
173acc7c Zhang Wei 2008-03-01  210  }
173acc7c Zhang Wei 2008-03-01  211  
173acc7c Zhang Wei 2008-03-01  212  /* There is no asm instructions for 64 bits reverse loads and stores */
173acc7c Zhang Wei 2008-03-01  213  static u64 in_le64(const u64 __iomem *addr)
173acc7c Zhang Wei 2008-03-01  214  {
a4e6d5d3 Al Viro   2008-03-29 @215  	return ((u64)in_le32((u32 __iomem *)addr + 1) << 32) |
a4e6d5d3 Al Viro   2008-03-29  216  		(in_le32((u32 __iomem *)addr));
173acc7c Zhang Wei 2008-03-01  217  }
173acc7c Zhang Wei 2008-03-01  218  
173acc7c Zhang Wei 2008-03-01  219  static void out_le64(u64 __iomem *addr, u64 val)
173acc7c Zhang Wei 2008-03-01  220  {
a4e6d5d3 Al Viro   2008-03-29 @221  	out_le32((u32 __iomem *)addr + 1, val >> 32);
a4e6d5d3 Al Viro   2008-03-29  222  	out_le32((u32 __iomem *)addr, (u32)val);
173acc7c Zhang Wei 2008-03-01  223  }
173acc7c Zhang Wei 2008-03-01  224  #endif
173acc7c Zhang Wei 2008-03-01  225  

:::::: The code at line 202 was first introduced by commit
:::::: a4e6d5d3817ebae167e78e5957cd9e624be200c7 fix the broken annotations in fsldma

:::::: TO: Al Viro <viro@xxxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux