On Wed, Dec 20, 2017 at 09:13:02AM +0000, Wen He wrote: > > > Okay, but DMA_IN/OUT need struct fsldma_chan. > > > May be I can refer to it that Implement a similar macro, will and below to > > instead it in next version. > > > > > > #define QDMA_IN(fsl_qdma_engine, addr) > > \ > > > (((fsl_qdma_engine)->big_endian & > > FSL_DMA_BIG_ENDIAN) ? \ > > > ioread32be(addr) : ioread32(addr)) > > > > > > #define QDMA_OUT(fsl_qdma_engine, addr, val) > > \ > > > (((fsl_qdma_engine)->big_endian & > > FSL_DMA_BIG_ENDIAN) ? \ > > > iowrite32be(val, addr) : iowrite32(val, addr)) > > > > Ah that would be duplicate. How about making it common and abstracting this > > as FSL_DMA_IN/OUT and using in both drivers? > > OK, but for now we are on rush to let this merged. Could we apply current version fist, > then I will discuss with author of that macro to get it done? Thank you. Am really sorry but that is not how upstreaming works. We dont do this and we certainly don't rush. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
