Re: [PATCH 0/5] dmaengine: ReSTize documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 31, 2017 at 02:16:14AM -0600, Jonathan Corbet wrote:
> On Wed, 25 Oct 2017 12:02:51 +0530
> Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> 
> > So here is the conversion of the dmaengine documents form txt files to rst
> > format. Not much functional change but somehow git detects only two renames
> > (possibly due to added indent to make new format happier)
> 
> Overall this looks pretty good, thanks.  I could pick out various nits
> (the use of single-space indents seems like an invitation for future
> editing errors, for example) but that's all second-order stuff.

Thanks for pointing, I will check. What is the indent preferred here?

> The bigger one is that I would really prefer to see this as part of the
> driver-api manual - that's what it's there for.  I would really rather
> that the top-level index file not replicate the unordered mess that is
> Documentation/ now.  Could we make that move as part of this change?

Sure, looking at it I agree that makes sense. Quick question though, should
we move the location of these files or just do references

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux