Hi, On Fri, 13 Oct 2017 12:43:46 +0200 Lucas Stach wrote: > The commit [1] which changed imx-pcm-dma to derive the pcm_config from the > attached dmaengine introduced a regression on the supported sample formats, > as imx-sdma doesn't properly advertise all the supported slave bus widths. > > Fix this to restore full functionality of the imx sound subsystem. > > [1] 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config") > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > --- > drivers/dma/imx-sdma.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index a67ec1bdc4e0..e374183f19d0 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1851,8 +1851,12 @@ static int sdma_probe(struct platform_device *pdev) > sdma->dma_device.device_prep_dma_cyclic = sdma_prep_dma_cyclic; > sdma->dma_device.device_config = sdma_config; > sdma->dma_device.device_terminate_all = sdma_disable_channel_with_delay; > - sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES); > - sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES); > + sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) | > + BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | > + BIT(DMA_SLAVE_BUSWIDTH_1_BYTE); > + sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) | > + BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | > + BIT(DMA_SLAVE_BUSWIDTH_1_BYTE); > sdma->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > sdma->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT; > sdma->dma_device.device_issue_pending = sdma_issue_pending; > Thank you, this fixes the regression I observed. Tested-by: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx> Lothar Waßmann -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html