On Mon, Oct 09, 2017 at 11:36:37AM +0100, Ed Blake wrote: > >>>> +static int img_mdc_runtime_suspend(struct device *dev) > >>>> +{ > >>>> + struct mdc_dma *mdma = dev_get_drvdata(dev); > >>>> + > >>>> + clk_disable_unprepare(mdma->clk); > >>>> + return 0; > >>>> +} > >>>> + > >>>> +static int img_mdc_runtime_resume(struct device *dev) > >>>> +{ > >>>> + struct mdc_dma *mdma = dev_get_drvdata(dev); > >>>> + > >>>> + return clk_prepare_enable(mdma->clk); > >>>> +} > >>> seems similar to the ones in prev, i guess we might be able to optimize > >>> > >> Sorry, what do you mean by 'the ones in prev'? > > ones in prev patch, see if you can modularize and use common helpers.. on a > > first glance seemed doable > > > > Do you mean the system PM functions added in the first patch? These > change in the second patch to re-use the runtime PM functions. Yes -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html